Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #116, Add UT failures to CI log #117

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Fix #116, Add UT failures to CI log #117

merged 1 commit into from
Aug 4, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jul 23, 2020

Describe the contribution
Fix #116
Failure now reported and test stops:

99% tests passed, 1 tests failed out of 73
Total Test time (real) = 145.89 sec
The following tests FAILED:
	 52 - network-api-test (Failed)
Errors while running CTest
Makefile:138: recipe for target 'test' failed
make: *** [test] Error 8
The command "make test" exited with 2.
$ if [[ -s build/native/Testing/Temporary/LastTestsFailed.log ]]; then
  echo "You must fix unit test errors before submitting a pull request"
  echo ""
  cat build/native/Testing/Temporary/LastTestsFailed.log
  grep "\[ FAIL\]" build/native/Testing/Temporary/LastTest.log
  exit -1
fi
You must fix unit test errors before submitting a pull request
52:network-api-test
[ FAIL] 02.014 network-api-test.c:375 - OS_SocketAccept() (0) == OS_SUCCESS

Testing performed
Ran with failure (and without), see output above.

Expected behavior changes
Just reports failure in ci log

System(s) tested on

  • CI with current bundle

Additional context
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper
Copy link
Contributor Author

skliper commented Jul 23, 2020

@yammajamma - This branch will log UT failures

@skliper
Copy link
Contributor Author

skliper commented Jul 29, 2020

Future - use less verbose report in CI, also resolve TSFs. Not a hold up on this.

@astrogeco
Copy link
Contributor

CCB 2020-07-29, APPROVED

@skliper
Copy link
Contributor Author

skliper commented Jul 29, 2020

@jphickey - running individual tests with "-v 5" worked, and make CTEST_OUTPUT_ON_FAILURE=1 test works, but I can't seem to find a way to combine the two just for CI (could hardcode the level to 5, but I'd rather not change current behavior).

@astrogeco astrogeco changed the base branch from master to main August 4, 2020 13:14
@astrogeco astrogeco merged commit 9def019 into nasa:main Aug 4, 2020
@astrogeco astrogeco added CCB:Approved Indicates code review and approval by community CCB and removed CCB:FastTrack labels Aug 4, 2020
PaulaBosca pushed a commit to McMasterNEUDOSE/cFS that referenced this pull request Aug 17, 2020
@avan989 @skliper
Fix nasa#117, Resolve cppcheck issues
9334835
PaulaBosca pushed a commit to McMasterNEUDOSE/cFS that referenced this pull request Aug 17, 2020
@skliper
CCB 20191218: Merge nasa#118 nasa#120
980b27e 
Fix nasa#117, nasa#119
Reviewed and approved at 2019-12-18 CCB
@skliper skliper deleted the fix116-report-ut-failure-ci branch January 28, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better failure reporting for unit tests in travis CI log
2 participants
@skliper @astrogeco